ferlagod/rocinante_android
ferlagod/rocinante_android
2
2
Fork 2
Code Issues Pull requests Projects Releases 18 Packages Wiki Activity Actions

search result popup: let user subscribe to author of a book review. sort reviews by date latest first #1

Closed
thrillfall wants to merge 0 commits from thrillfall/rocinante_android:main into main
pull from: thrillfall/rocinante_android:main
merge into: ferlagod:main
Conversation 1 Commits - Files changed -
thrillfall commented 2026-06-15 11:56:28 +00:00
First-time contributor
Copy link
No description provided.
signal-2026-06-15-135714.jpeg
79 KiB
signal-2026-06-15-135714.jpeg
ferlagod commented 2026-06-15 15:03:48 +00:00
Owner
Copy link

Hi @thrillfall!

Thank you so much for this Pull Request. I've been reviewing and testing it locally and it works perfectly.

I really liked how you handled the ActivityPub handle resolution (@user@instance) for federated authors, and the regex parsing for the BookWyrm dates so we can finally sort the reviews chronologically. Also, separating the .debug build applicationId is a great quality-of-life addition that will be super useful to test things without overwriting the F-Droid install.

The code is really clean and integrates beautifully with the app's architecture. I've just merged it into the main branch.

Thanks again for your time and for this great contribution to Rocinante! You're welcome to contribute again anytime.

Hi @thrillfall! Thank you so much for this Pull Request. I've been reviewing and testing it locally and it works perfectly. I really liked how you handled the ActivityPub handle resolution (@user@instance) for federated authors, and the regex parsing for the BookWyrm dates so we can finally sort the reviews chronologically. Also, separating the .debug build applicationId is a great quality-of-life addition that will be super useful to test things without overwriting the F-Droid install. The code is really clean and integrates beautifully with the app's architecture. I've just merged it into the main branch. Thanks again for your time and for this great contribution to Rocinante! You're welcome to contribute again anytime.
ferlagod closed this pull request 2026-06-16 13:38:47 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ferlagod/rocinante_android!1
No description provided.